Bug 7919 - upgradeprovision output and help messages
Summary: upgradeprovision output and help messages
Status: RESOLVED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: Tools (show other bugs)
Version: unspecified
Hardware: All All
: P3 minor (vote)
Target Milestone: ---
Assignee: Matthieu Patou
QA Contact: samba4-qa@samba.org
URL: http://lists.samba.org/archive/samba-...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-14 15:22 UTC by Michael Wood
Modified: 2011-02-13 08:51 UTC (History)
0 users

See Also:


Attachments
Fix typo I introduced in previous patch and use better word. (1.40 KB, patch)
2011-01-14 15:23 UTC, Michael Wood
no flags Details
Proposal for --debugguess help message. (1.16 KB, patch)
2011-01-14 15:25 UTC, Michael Wood
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Wood 2011-01-14 15:22:04 UTC
Hi

On 8 January 2011 00:29, Matthieu Patou <mat at samba.org> wrote:
> On 05/01/2011 04:57, Michael Wood wrote:
[...]
>> The help message for --setupdir says "directory with setup files".
>> What are "setup files" in the context of upgradeprovision?

I still don't know what is meant by "setup files".

>> The help message for --debugguess is identical to the one for
>> --debugchange.  I suspect the --debugguess one should say something
>> like "Print information on which values are guessed"?

I've attached a proposal for fixing the --debugguess help message.

[...]
>> Anyway, I've attached a patch.  Please apply it if you are happy with
>> the changes.

I noticed a typo that I introduced and also changed a "when" to
"while", which I think is better.  I have attached that patch too.

> Thanks !
> Signed it off.

Thanks :)

-- 
Michael Wood <esiotrot at gmail.com>
Comment 1 Michael Wood 2011-01-14 15:23:52 UTC
Created attachment 6204 [details]
Fix typo I introduced in previous patch and use better word.
Comment 2 Michael Wood 2011-01-14 15:25:24 UTC
Created attachment 6205 [details]
Proposal for --debugguess help message.
Comment 3 Matthieu Patou 2011-02-13 08:51:18 UTC
Micheal, pushed and signed off to my tree. Thanks for the contribution sorry for the long delay to process your patches.