Bug 7894 - sporadic winbind panic in query_user_list (triggered e.g. by wbinfo -u)
sporadic winbind panic in query_user_list (triggered e.g. by wbinfo -u)
Product: Samba 3.5
Classification: Unclassified
Component: Winbind
Other All
: P3 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2010-12-30 04:12 UTC by Michael Adam
Modified: 2010-12-31 13:01 UTC (History)
2 users (show)

See Also:

patch with bugfix for 3.5 (1.02 KB, patch)
2010-12-30 04:26 UTC, Michael Adam
metze: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adam 2010-12-30 04:12:24 UTC
In winbind_rpc.c:query_user_list, the return code of rpccli_samr_QueryDisplayInfo() is not properly evaluated
before accessing the disp_info results, which leads to
an error if the rpccli command failed.

Patch follows next...
Comment 1 Michael Adam 2010-12-30 04:15:40 UTC
btw:  this is in the rpc methods
Comment 2 Michael Adam 2010-12-30 04:26:27 UTC
Created attachment 6177 [details]
patch with bugfix for 3.5

Fix that applies to v3-5-test.

This is the way master also does this, but here the fix was
introduced in a refactoring commit c83e8cbe4ae3192b576b47bfae2a4ba90d6e0ce9.

I am not 100% sure that this is correct in all cases
(e.g., what if NT_STATUS_NO_MORE_ENTRIES is returned?
should we pass that on or return NT_STATUS_OK intstead?)
But all my tests were ok with the patch.
Comment 3 Stefan Metzmacher 2010-12-30 04:33:04 UTC
Comment on attachment 6177 [details]
patch with bugfix for 3.5

Looks, good and matches the logic v3-6-test and master
Comment 4 Karolin Seeger 2010-12-31 13:01:30 UTC
Pushed to v3-5-test.
Will be included in the next release.
Closing out bug report.