Bug 7875 - nmbd --port not working
Summary: nmbd --port not working
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: Nmbd (show other bugs)
Version: 3.5.6
Hardware: x86 Linux
: P3 trivial
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-20 04:03 UTC by Manish M Yathnalli
Modified: 2011-01-11 14:31 UTC (History)
2 users (show)

See Also:

Attachments
fix (1.17 KB, patch)
2011-01-07 09:30 UTC, Björn Baumbach 		metze: review+
obnox: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manish M Yathnalli 2010-12-20 04:03:50 UTC 
nmbd --port command will not be parsed. It gives unknown error.
Comment 1 Björn Baumbach 2011-01-07 09:30:55 UTC 
Created attachment 6187 [details]
fix
Comment 2 Stefan Metzmacher 2011-01-07 10:05:04 UTC 
I've pushed that to autobuild
Comment 3 Stefan Metzmacher 2011-01-10 02:59:07 UTC 
Cherry-picked to v3-6-test
Comment 4 Björn Baumbach 2011-01-10 06:50:41 UTC 
Patch applies on v3-4-test and v3-5-test, too.
Comment 5 Stefan Metzmacher 2011-01-10 07:04:34 UTC 
Comment on attachment 6187 [details]
fix

Looks good
Comment 6 Michael Adam 2011-01-11 03:23:35 UTC 
Comment on attachment 6187 [details]
fix

Hm, does the bug description and commit message match the patch? It seems to me that the patch also modifies the behaviour of the --hosts parameter. I have to admit that I apparently don't really understand the "val" member of the struct poptOption yet...

Ok, now I seem to start to understand... :-) It is meant to indicate via the return value of poptGetNextOpt(), which option was really parsed last. So in the case of nmbd, --hosts and --port yielded the "Invalid option" error messsage.

The patch is correct, but it fixes more than the the bug report (and the commit message) actually list.

Sorry for the gibberish, I needed it to understand.
Comment 7 Michael Adam 2011-01-11 03:24:56 UTC 
==> Karolin
Comment 8 Karolin Seeger 2011-01-11 14:31:40 UTC 
Pushed to v3-5-test and v3-4-test.
Closing out bug report.

Thanks!