Bug 7871 - net ads: dynamic dns updates registers wrong list of addresses if "clustering = yes"
Summary: net ads: dynamic dns updates registers wrong list of addresses if "clustering...
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: Client Tools (show other bugs)
Version: 3.5.6
Hardware: All Linux
: P3 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
Depends on:
Reported: 2010-12-16 02:52 UTC by Michael Adam
Modified: 2010-12-26 15:11 UTC (History)
2 users (show)

See Also:

patchset for master (7.24 KB, patch)
2010-12-16 03:01 UTC, Michael Adam
no flags Details
Backport Patch for v3-5-test (12.63 KB, patch)
2010-12-18 02:40 UTC, Stefan Metzmacher
obnox: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adam 2010-12-16 02:52:46 UTC
The magic of determining all addresses for dns updates in "net ads join" and "net ads dns register" is useless and leads to wrong results if "clustering = yes".

Firstly, it only takes into account the addresses local to the node on which the command is run.

Secondly, it usually assigns too many addresses from the node: In clustered samba, samba usually listens on the wildcard interface but effectively serves only the addresses that are ctdb's "public addresses".

So the default behaviour is wrong for "clustering = yes".
Comment 1 Michael Adam 2010-12-16 03:01:12 UTC
Created attachment 6136 [details]
patchset for master

This is a patchset for master.
It does two things:

1. disables the dns updates for net ads join if "clustering = yes"

2. adds support for specifying IPs on the commandline of "net ads dns register"
   and refuses to do updates if "clustering = yes " and no IPs are explicitly specified.

Comments, please....
Comment 2 Stefan Metzmacher 2010-12-16 11:22:02 UTC
I'll extend the patches to support "cluster addresses" and push them to master
and v3-6-test. I'll propose a backport for 3.5.x here.
Comment 3 Stefan Metzmacher 2010-12-18 02:40:43 UTC
Created attachment 6151 [details]
Backport Patch for v3-5-test
Comment 4 Michael Adam 2010-12-18 05:35:42 UTC
Comment on attachment 6151 [details]
Backport Patch for v3-5-test

Metze, thanks for extending this to use cluster addresses. I was not aware that it was so easy. :-)

Karolin: please pick for 3.5.7
Comment 5 Michael Adam 2010-12-18 05:36:12 UTC
==> Karolin
Comment 6 Karolin Seeger 2010-12-26 15:11:07 UTC
Pushed to v3-5-test.
Closing out bug report.