We have a lot of places where we have code like this: if (!NT_STATUS_IS_OK(cli_session_setup(cli, l_username, l_password, strlen(l_password), l_password, strlen(l_password), lp_workgroup()))) { d_printf("session setup failed: %s\n", cli_errstr(cli)); return -1; } This prints: session setup failed: SUCCESS - 0 Instead of using cli_errstr(cli) we should use the NTSTATUS returned by the function. At the same time we could use remove the cli_* calls from the if statement... As a quick hack we might add a change that updates the info that cli_errstr() uses.
This is part of the continuous refactoring of the client libs. Feel free to contribute :-) Volker
.
Created attachment 6736 [details] Patch for v3-6-test I think this should be included in 3.6.1.
Comment on attachment 6736 [details] Patch for v3-6-test Yep, 3.6.1 material. Thanks! Volker
Pushed to v3-6-test. Closing out bug report. Thanks!