Bug 7853 - RPC-SRVSVC tests functions that Windows does not support over the wire
RPC-SRVSVC tests functions that Windows does not support over the wire
Status: NEW
Product: Samba 4.0
Classification: Unclassified
Component: smbtorture
unspecified
Other Windows NT
: P3 normal
: ---
Assigned To: Andrew Bartlett
samba4-qa@samba.org
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-12-07 19:12 UTC by Matt Ficken
Modified: 2010-12-07 19:12 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Ficken 2010-12-07 19:12:23 UTC
Samba defines 8 functions from the MS-SRVS protocol that [MS-SRVS] states are not to be used on the wire. Specifically, they are: 
NDR_SRVSVC_NETCHARDEVENUM (0x00)
NDR_SRVSVC_NETCHARDEVGETINFO (0x01)
NDR_SRVSVC_NETCHARDEVCONTROL (0x02)
NDR_SRVSVC_NETCHARDEVQENUM (0x03)
NDR_SRVSVC_NETCHARDEVQGETINFO (0x04)
NDR_SRVSVC_NETCHARDEVQSETINFO (0x05)
NDR_SRVSVC_NETCHARDEVQPURGE (0x06)
NDR_SRVSVC_NETCHARDEVQPURGESELF (0x07)
NDR_SRVSVC_NETCONNENUM (0x08)

The IDL in Appendix A in [MS-SRVS] states that opnums 0-8(inclusive) are not used on wire, that is, Windows will return NT_STATUS_INVALID_PARAMETER or other error code if they are used.

Samba implements and the RPC-SRVSVC suite tests these functions anyway.

Roughly, [MS-SRVS] provides an RPC based replacement for [MS-RAP], and [MS-RAP] doesn't have functions for remotely working with Character Devices (NetCharDevEnum, etc...).

Samba(at least Samba4.0.0alpha12-GIT-72cd5bc) doesn't implement these functions and instead returns WERR_NOT_SUPPORTED. So Samba should fail this suite too.

Further, its hard to see what use NetCharDevEnum, etc... would have over a network, other than being a security hole. 

Therefore, I believe the WSPP documentation ([MS-SRVS]) is correct in this case.


If Samba wants to extend [MS-SRVS] by implementing and using these functions when targeting another Samba host, thats certainly ok.

However, Windows doesn't support that extension of [MS-SRVS].

Samba, as in the RPC-SRVSVC test suite, or smbd, or smbclient, must not use opnums 0-8 on the srvsvc interface when targeting a Windows host.