Bug 7814 - Compile Error with Kernelheders 2.6.36
Compile Error with Kernelheders 2.6.36
Product: Samba 3.5
Classification: Unclassified
Component: Build environment
x86 Linux
: P3 minor
: ---
Assigned To: Karolin Seeger
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2010-11-23 11:34 UTC by Markus Königshaus
Modified: 2012-09-17 09:55 UTC (History)
1 user (show)

See Also:

fix for 3.5 (1.05 KB, patch)
2012-09-13 07:30 UTC, Björn Jacke
metze: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Königshaus 2010-11-23 11:34:32 UTC
Trying to compile Samba-3.5.6 with Kernelheaders 2.6.36 fails at sysquotas_xfs.c because the XFS_QUOTA_XXX defines were renamed to FS_QUOTA_XXX. Renaming the the macros in sysquotas_xfs.c to FS_QUOTA_XXX solves this problem.
Comment 1 Björn Jacke 2012-09-13 07:30:17 UTC
Created attachment 7888 [details]
fix for 3.5

thanks for the report! that finally explains why it doesn't build with the kernel header file anymore but only with the xfs header file that the man page of quotactl() recommends. In master this is fixed by using the recommended include. For 3.5 the attached patch fixes it with minimal changes.
Comment 2 Stefan Metzmacher 2012-09-13 11:43:59 UTC
Comment on attachment 7888 [details]
fix for 3.5

Looks ok
Comment 3 Stefan Metzmacher 2012-09-13 11:44:32 UTC
Karolin, please pick for the next release
Comment 4 Karolin Seeger 2012-09-17 09:55:06 UTC
Pushed to v3-5-test.
Will be included in the next bugfix release.
Closing out bug report.