Bug 7800 - winbind does not recover from smb signing errors
Summary: winbind does not recover from smb signing errors
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: Winbind (show other bugs)
Version: unspecified
Hardware: Other All
: P3 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-18 06:27 UTC by Volker Lendecke
Modified: 2010-11-24 11:28 UTC (History)
1 user (show)

See Also:

Attachments
Patch for 3.5 (1.09 KB, patch)
2010-11-18 06:30 UTC, Volker Lendecke 		metze: review+
Details
Patch for 3.4 (1.11 KB, patch)
2010-11-18 07:16 UTC, Volker Lendecke 		metze: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Volker Lendecke 2010-11-18 06:27:24 UTC 
When winbind sees a signing error on the smb connection to a DC (for whatever reason, our bug, network glitch, etc) it should recover properly. The "old" code in clientgen.c just closed the socket in this case. This is the right thing to do, this connection is spoiled anyway. The new, async code did not do this so far, which led to the code in winbindd_cm.c not detect that we need to reconnect.
Comment 1 Volker Lendecke 2010-11-18 06:30:45 UTC 
Created attachment 6071 [details]
Patch for 3.5
Comment 2 Stefan Metzmacher 2010-11-18 07:04:22 UTC 
Comment on attachment 6071 [details]
Patch for 3.5

Looks ok, while just looking at the patch
Comment 3 Stefan Metzmacher 2010-11-18 07:05:20 UTC 
Karolin, please pick for the next release.
Comment 4 Volker Lendecke 2010-11-18 07:16:59 UTC 
Created attachment 6072 [details]
Patch for 3.4

Equivalent patch for 3.4 which also suffers from this problem
Comment 5 Stefan Metzmacher 2010-11-18 11:49:03 UTC 
Comment on attachment 6072 [details]
Patch for 3.4

Looks good
Comment 6 Karolin Seeger 2010-11-24 11:28:39 UTC 
Pushed to v3-4-test and v3-5-test.
Closing out bug report.

Thanks!