Bug 7791 - gvfsd-smb (Gnome vfs) fails to copy files from a SMB share using SMB signing.
gvfsd-smb (Gnome vfs) fails to copy files from a SMB share using SMB signing.
Product: Samba 3.5
Classification: Unclassified
Component: libsmbclient
All Linux
: P3 critical
: ---
Assigned To: Karolin Seeger
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2010-11-10 19:11 UTC by Jeremy Allison
Modified: 2010-11-16 08:53 UTC (History)
0 users

See Also:

git-am fix for 3.5.7. (1.52 KB, patch)
2010-11-11 11:46 UTC, Jeremy Allison
jra: review? (metze)
vl: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2010-11-10 19:11:04 UTC
Link to Gnome bug:


Patch tested in gnome. Patch to follow.

Comment 1 Jeremy Allison 2010-11-10 19:18:16 UTC
The underlying problem is that the old code invoked by cli_write() increments cli->mid directly when issuing outstanding writes. This should now be done only in libsmb/clientgen.c to make metze's new signing engine work correctly. Just deleting this code fixes the problem.
Comment 2 Jeremy Allison 2010-11-10 19:36:38 UTC
I'm working on adding a smbtorture test for this before checking in the patch.
Comment 3 Jeremy Allison 2010-11-11 11:46:16 UTC
Created attachment 6062 [details]
git-am fix for 3.5.7.

Original Gnome submitter reports this fixes the bug.
Comment 4 Jeremy Allison 2010-11-11 11:46:57 UTC
Raised priority to critical as this breaks Gnome desktop copying to all signed servers.
Comment 5 Karolin Seeger 2010-11-16 08:53:32 UTC
Pushed to v3-5-test.
Closing out bug report.