Bug 7791 - gvfsd-smb (Gnome vfs) fails to copy files from a SMB share using SMB signing.
Summary: gvfsd-smb (Gnome vfs) fails to copy files from a SMB share using SMB signing.
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: libsmbclient (show other bugs)
Version: 3.5.6
Hardware: All Linux
: P3 critical
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-10 19:11 UTC by Jeremy Allison
Modified: 2020-12-11 07:24 UTC (History)
0 users

See Also:

Attachments
git-am fix for 3.5.7. (1.52 KB, patch)
2010-11-11 11:46 UTC, Jeremy Allison 		vl: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2010-11-10 19:11:04 UTC 
Link to Gnome bug:

https://bugzilla.gnome.org/show_bug.cgi?id=633937

Patch tested in gnome. Patch to follow.

Jeremy.
Comment 1 Jeremy Allison 2010-11-10 19:18:16 UTC 
The underlying problem is that the old code invoked by cli_write() increments cli->mid directly when issuing outstanding writes. This should now be done only in libsmb/clientgen.c to make metze's new signing engine work correctly. Just deleting this code fixes the problem.
Jeremy.
Comment 2 Jeremy Allison 2010-11-10 19:36:38 UTC 
I'm working on adding a smbtorture test for this before checking in the patch.
Jeremy.
Comment 3 Jeremy Allison 2010-11-11 11:46:16 UTC 
Created attachment 6062 [details]
git-am fix for 3.5.7.

Original Gnome submitter reports this fixes the bug.
Comment 4 Jeremy Allison 2010-11-11 11:46:57 UTC 
Raised priority to critical as this breaks Gnome desktop copying to all signed servers.
Comment 5 Karolin Seeger 2010-11-16 08:53:32 UTC 
Pushed to v3-5-test.
Closing out bug report.

Thanks!