Bug 7622 - Factor out common logic from itemize and unchanged_attrs functions
Summary: Factor out common logic from itemize and unchanged_attrs functions
Status: NEW
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.0
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-15 12:44 UTC by Matt McCutchen
Modified: 2011-06-26 20:46 UTC (History)
0 users

See Also:

Attachments
Patch (8.58 KB, patch)
2011-06-26 20:46 UTC, Matt McCutchen 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt McCutchen 2010-08-15 12:44:08 UTC 
There is a lot of logic duplicated between these two functions.  Factoring it out would make it easier to add support for preserving new attributes and would cut down on the number of bugs in one function but not the other, such as:

https://lists.samba.org/archive/rsync/2008-March/020276.html
bug 7618
Comment 1 Matt McCutchen 2011-06-26 20:46:51 UTC 
Created attachment 6630 [details]
Patch

W00t!  My first patch since about a year ago!  Also in my repository at https://mattmccutchen.net/rsync/rsync.git/?a=commitdiff;h=ddc5ae3d9e6cc632b93bac327b6f92d0545b0537 .