Bug 7620 - AIX build broken due to gcc'ism
Summary: AIX build broken due to gcc'ism
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: Build environment (show other bugs)
Version: unspecified
Hardware: Other All
: P3 normal
Target Milestone: ---
Assignee: Kai Blin
QA Contact: Samba QA Contact
Depends on:
Reported: 2010-08-13 09:23 UTC by Björn Jacke
Modified: 2011-05-23 20:19 UTC (History)
0 users

See Also:

Fix for netgrent checks on compilers that don't support -Werror-implicit-function-declaration (1.00 KB, patch)
2010-08-14 00:45 UTC, Kai Blin
kai: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2010-08-13 09:23:57 UTC
ff32f691bba41afab45efe7e21a2c91bb2c157bb uses -Werror-implicit-function-declaration (a GCC only thing) which makes the test fail on AIX and later on makes the build fail.
Comment 1 Kai Blin 2010-08-13 11:13:48 UTC
-Werror-implicit-function-declaration is the core part of the current check. The check is needed to support this API on different OSX/NetBSD versions. Feel free to fix the whole check, but this was the only one I could come with that worked correctly on the systems I tried this on.
Comment 2 Kai Blin 2010-08-14 00:45:12 UTC
Created attachment 5904 [details]
Fix for netgrent checks on compilers that don't support -Werror-implicit-function-declaration

This works on my Linux box, don't currently have access to the OSX box where I saw the initial problem. Please check if the patch fixes AIX, I'll confirm that it still works on OSX once I get back to that machine.
Comment 3 Björn Jacke 2010-08-14 07:30:58 UTC
looks more reasonable but I have not tested it but at least it does not use a gcc-only option unconditionally :-). I suppose just check it in to master and see if it works. You can also log in to SerNet-aix (also sunX with the studio compiler is affected by that).
Comment 4 Kai Blin 2010-08-21 09:46:48 UTC
Looks fixed on the build farm.
Comment 5 Kai Blin 2011-05-23 20:19:48 UTC
Comment on attachment 5904 [details]
Fix for netgrent checks on compilers that don't support -Werror-implicit-function-declaration

Clearing up old requests