Bug 7576 - Correct shared lib linking with OpenBSD.
Correct shared lib linking with OpenBSD.
Status: RESOLVED WORKSFORME
Product: Samba 3.5
Classification: Unclassified
Component: Build environment
3.5.4
All OpenBSD
: P3 normal
: ---
Assigned To: Björn Jacke
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-17 17:10 UTC by Brad Smith
Modified: 2010-08-02 04:30 UTC (History)
0 users

See Also:


Attachments
autoconf patch (423 bytes, patch)
2010-07-17 17:11 UTC, Brad Smith
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Smith 2010-07-17 17:10:51 UTC
The attached patch corrects the building for shared libs with OpenBSD. The patch is for Samba 3.5 although the same issue exists with 3.4 and future releases.
Comment 1 Brad Smith 2010-07-17 17:11:28 UTC
Created attachment 5849 [details]
autoconf patch
Comment 2 Björn Jacke 2010-07-19 05:21:32 UTC
the removal of the SONAMEFLAG definition looks a bit odd. Doesn't the correction of DYNEXP alone fix your ploblems?

Can you please post the errors that you see?
Comment 3 Brad Smith 2010-07-19 09:42:24 UTC
OpenBSD does not use SONAME so it should not be passed on the commandline.
Comment 4 Brad Smith 2010-08-01 15:53:21 UTC
Bump.
Comment 5 Björn Jacke 2010-08-01 16:48:01 UTC
As already asked before: Can you please post the errors that you see?

Can you also point to some documentation about that? At least http://www.openbsd.org/cgi-bin/man.cgi?query=ld&sektion=1 lists -soname as a valid option on OpenBSD.
Comment 6 Brad Smith 2010-08-01 16:54:44 UTC
There are no errors to show. It'll link a library at the moment but the parameters being used are not correct for OpenBSD.

There is no documentation mentioning the OpenBSD specific behavior of the linker. The man pages are the standard GNU binutils man pages.

This is what we use in our port/package already..
http://www.openbsd.org/cgi-bin/cvsweb/ports/net/samba/patches/patch-configure_in
Comment 7 Björn Jacke 2010-08-02 04:30:34 UTC
if there are "no errors" and if there is no documentation about the use or misuse of the parameter in OpenBSD, I personally don't want to change anything here. Currently we are along with the documentation and we see no error, so I actually also don't see anything to fix. Two OpenBSD machines in the build farm also show no error in this regard. Not that I don't trust what you say but "fixing" something undocumented that does not even show up in any error seems not to be a good thing to do. I might change my mind if there is any documentation about this telling that discourages the use of soname or any error that results in the current way the soname option is used.