Bug 7559 - Backport change notify alignment fix 00056e73
Backport change notify alignment fix 00056e73
Status: NEW
Product: Samba 3.5
Classification: Unclassified
Component: File services
unspecified
All All
: P3 major
: ---
Assigned To: Volker Lendecke
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-06 15:34 UTC by Steven Danneman
Modified: 2011-05-11 15:23 UTC (History)
0 users

See Also:


Attachments
additional patch to switch to autogenerated marshalling (5.91 KB, patch)
2010-07-06 18:58 UTC, Guenther Deschner
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steven Danneman 2010-07-06 15:34:13 UTC
Win7 clients will close a change notify handle if the server doesn't follow
a 4-byte alignment in its replies.

This should be backported from master to the 3.5 and 3.4 branches.
Comment 1 Guenther Deschner 2010-07-06 18:58:36 UTC
Created attachment 5830 [details]
additional patch to switch to autogenerated marshalling

Volker, once you reviewed Stevens patch, would you mind to look at this one too ?

It switches to autogenerated marshalling for that struct (and kills one of the very few remaining UNISTR we still have).
Comment 2 Guenther Deschner 2010-07-07 09:54:40 UTC
(In reply to comment #1)
> Created an attachment (id=5830) [details]
> additional patch to switch to autogenerated marshalling
> 
> Volker, once you reviewed Stevens patch, would you mind to look at this one too
> ?
> 
> It switches to autogenerated marshalling for that struct (and kills one of the
> very few remaining UNISTR we still have).

pushed that after doing very careful testing. no need to review any more.
Comment 3 Steven Danneman 2010-07-07 12:23:06 UTC
Guenter made my fix much better, though backporting the initial commit (00056e73)
should be all that's required for 3.4 and 3.5.
Comment 4 Guenther Deschner 2011-05-11 15:23:26 UTC
3.5 (and 3.4) issue, not 3.6