Bug 7463 - wrong include order in ...lib/util/tevent_unix.c
Summary: wrong include order in ...lib/util/tevent_unix.c
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.5.3
Hardware: Other Other
: P3 normal
Target Milestone: ---
Assignee: Björn Jacke
QA Contact: Samba QA Contact
Depends on:
Reported: 2010-05-27 10:16 UTC by Joachim Schmitz (mail address dead)
Modified: 2010-09-22 12:24 UTC (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Joachim Schmitz (mail address dead) 2010-05-27 10:16:26 UTC
in ...lib/util/tevent_unix.c I had to reverse the oder of includes to make it compile, it had conflicts otherwise. Patch:

diff -u ./lib/util/tevent_unix.c.orig ./lib/util/tevent_unix.c
--- ./lib/util/tevent_unix.c.orig       2010-05-17 06:51:23.000000000 -0500
+++ ./lib/util/tevent_unix.c    2010-05-27 05:14:34.000000000 -0500
@@ -21,8 +21,8 @@
    along with this program.  If not, see <http://www.gnu.org/licenses/>.

-#include "tevent_unix.h"
 #include "../replace/replace.h"
+#include "tevent_unix.h"

 bool tevent_req_is_unix_error(struct tevent_req *req, int *perrno)

Bye, Jojo
Comment 1 Joachim Schmitz (mail address dead) 2010-05-27 10:17:54 UTC
Of course I meant 'order' rather than 'oder' ...
Comment 2 Björn Jacke 2010-09-21 21:15:24 UTC
fixed in master and soon on 3.6. Just for completeness: can you tell which exact error you got?
Comment 3 Joachim Schmitz (mail address dead) 2010-09-22 01:27:42 UTC
I don't remember, some macro being redefined I think? And when I tried again today, there was no error anymore?!
Maybe a change between 3.5.3 (where I first found that problem) and 3.5.5 (which I'm using now) is responsible for the error to disappear?

Comment 4 Björn Jacke 2010-09-22 12:22:55 UTC
okay, never mind, thanks for taking care!
Comment 5 Björn Jacke 2010-09-22 12:24:00 UTC