...lib/tevent/tevent_signal.c used SA_RESETHAND twice. This is none-standard and not available universaly. Don't have a good idea how fix this, other than just disabling that part? diff -u ./lib/tevent/tevent_signal.c.orig ./lib/tevent/tevent_signal.c --- ./lib/tevent/tevent_signal.c.orig 2010-05-17 06:51:23.000000000 -0500 +++ ./lib/tevent/tevent_signal.c 2010-05-26 08:21:33.000000000 -0500 @@ -352,16 +355,20 @@ (void*)&sig_state->sig_info[i][ofs], se->private_data); } #ifdef SA_RESETHAND if (se->sa_flags & SA_RESETHAND) { talloc_free(se); } +#endif continue; } #endif se->handler(ev, se, i, count, NULL, se->private_data); #ifdef SA_RESETHAND if (se->sa_flags & SA_RESETHAND) { talloc_free(se); } +#endif } #ifdef SA_SIGINFO Bye, Jojo
The actual problem seems to be in .../lib/replace/system/wait.h, which #define's SA_RESETHANT to SA_ONESHOT it not #define'd before, without checking wheter SA_ONESHOT exists. So my patch should actually check for SA_ONESHOT rather than SA_RESETHAND. Bye, Jojo
Created attachment 5753 [details] Patch
Metze, can you have a look how this could be solved?
Created attachment 5986 [details] patch I believe this patch is cleaner. It still doesn't solve the case when neither SA_RESETHAND not SA_ONESHOT is available (other than to make tervent_signal.c compile), but this may not be fixable at all?
still an issue in 3.5.7
Jeremy, Tridge you are the signal experts, any ideas on this?
Hi there I'm currently out of office and will be back on Monday, the 15th of August 2011. I may occasionally have access to email during my absence, but don't hold your breath on it, I'll surely deal with them after my return. For urgent business matters please contact either my manager Thomas Petrausch (mailto:thomas.petrausch@hp.com) or call HP's Global NonStop Solution Center (for the numbers check http://h20195.www2.hp.com/V2/GetPDF.aspx/c02083951.pdf) and ask for the Duty Manager. On existing cases you may also send an email to GNSC (mailto:gcsc@hp.com) and mention the case number. For urgent private matters call me on my mobile phone, if you don't have the number, well, then it's probably not much of a private matter ;-). Note: this message will be send to you only once during my absence! Bye, Joachim 'Jojo' Schmitz NonStop and Neoview Support Expert Global NonStop Solution Centre (GNSC) Europe, Middle East, Africa Hewlett-Packard GmbH
SA_ONESHOT is a linux-only thing isn't it ? The safest thing is just to conditionally guard all uses of SA_RESETHAND and not define it in lib/replace if it doesn't exist on the system. It isn't used in any Samba code except for tevent testing code. Modified patch to follow. Jeremy
FYI. SA_RESETHAND is part of the Posix standard.
Created attachment 6744 [details] Patch for 3.5.x.
Comment on attachment 6744 [details] Patch for 3.5.x. Looks ok
Karolin, please pick for the next 3.5 release Jeremy, can you upload a patch for 3.6.x?
Created attachment 6747 [details] git-am fix for 3.6.0.
Comment on attachment 6747 [details] git-am fix for 3.6.0. Looks good
Karolin, please pick for the release
Pushed to v3-6-test and v3-5-test. Closing out bug report. Thanks!