Bug 7443 - Fake Oplocks don't work for SMB2.
Summary: Fake Oplocks don't work for SMB2.
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: x64 Solaris
: P3 minor
Target Milestone: ---
Assignee: Volker Lendecke
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-20 10:15 UTC by Ira Cooper
Modified: 2010-05-21 12:32 UTC (History)
0 users

See Also:

Attachments
Patch for the problem. (1.87 KB, patch)
2010-05-20 10:17 UTC, Ira Cooper 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ira Cooper 2010-05-20 10:15:07 UTC 
The current fake oplocks implementation doesn't work for SMB2, the normal oplocks code seems to still be engaged.
Comment 1 Ira Cooper 2010-05-20 10:17:51 UTC 
Created attachment 5723 [details]
Patch for the problem.
Comment 2 Jeremy Allison 2010-05-20 13:38:34 UTC 
I'm going to check this in but rename the variable "fake_in_oplock_level" to "requested_oplock_level" to more accurately reflect what it represents.

Thanks,

Jeremy.
Comment 3 Ira Cooper 2010-05-20 15:45:10 UTC 
I have no issue with that change.

Thanks,

-Ira
Comment 4 Jeremy Allison 2010-05-21 12:32:48 UTC 
Pushed to master - commit 28b8d421364a1d55bf28a2552f58b5e4325d2bbb.
Closing out bug report - thanks !
Jeremy.