Bug 7421 - samba 3.4.7 does not compile on AIX 6.1
samba 3.4.7 does not compile on AIX 6.1
Status: RESOLVED FIXED
Product: Samba 3.4
Classification: Unclassified
Component: File services
3.4.7
PPC AIX
: P3 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-11 01:39 UTC by Olaf Flebbe
Modified: 2010-05-12 03:20 UTC (History)
0 users

See Also:


Attachments
patch to undef mod_name (312 bytes, text/plain)
2010-05-11 01:40 UTC, Olaf Flebbe
vl: review-
Details
patch for samba 3.4.x (2.82 KB, patch)
2010-05-11 07:50 UTC, Olaf Flebbe
vl: review+
abartlet: review+
Details
Patch for master/3.5 (2.82 KB, patch)
2010-05-11 08:12 UTC, Volker Lendecke
abartlet: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Olaf Flebbe 2010-05-11 01:39:13 UTC
The file libnet_samsync_ldif.c does not compile because mod_name is #defined in <stropts.h>. name space pollution ;-(

Error message is:
"libnet/libnet_samsync_ldif.c", line 60.15: 1506-277 (S) Syntax error: possible 
missing ';' or ','?

Please apply patch to 3.4.7  (it seems to be need even in samba-3.5.x and master)
Comment 1 Olaf Flebbe 2010-05-11 01:40:49 UTC
Created attachment 5693 [details]
patch to undef mod_name
Comment 2 Volker Lendecke 2010-05-11 03:12:55 UTC
The way to deal with these things so far has been to rename the offending variable. I would recommend "module_name" instead of "mod_name" here.

Thanks,

Volker
Comment 3 Volker Lendecke 2010-05-11 03:23:25 UTC
Comment on attachment 5693 [details]
patch to undef mod_name

As said in an earlier comment: Please rename mod_name. You might also propose something similar for source4/lib/com/tables.c.
Comment 4 Olaf Flebbe 2010-05-11 07:50:11 UTC
Created attachment 5694 [details]
patch for samba 3.4.x
Comment 5 Olaf Flebbe 2010-05-11 07:50:45 UTC
Added tested patch 
Comment 6 Volker Lendecke 2010-05-11 08:10:31 UTC
Comment on attachment 5694 [details]
patch for samba 3.4.x

Looks good to me
Comment 7 Volker Lendecke 2010-05-11 08:11:16 UTC
Comment on attachment 5694 [details]
patch for samba 3.4.x

Andrew, this touches source4/. Please review and ack.

Thanks,

Volker
Comment 8 Volker Lendecke 2010-05-11 08:12:04 UTC
Created attachment 5695 [details]
Patch for master/3.5

Patch for master and 3.5
Comment 9 Andrew Bartlett 2010-05-11 17:00:43 UTC
What a weird and annoying bug!

The patches are fine.  Please apply. 
Comment 10 Volker Lendecke 2010-05-12 00:17:06 UTC
Karolin, please pull the patches into the relevant branches.

Thanks,

Volker
Comment 11 Karolin Seeger 2010-05-12 03:20:46 UTC
Pushed to v3-5-test and v3-4-test.
Closing out bug report.

Thanks!