Bug 7384 - dptr_Close has a bitmap leak.
dptr_Close has a bitmap leak.
Product: Samba 3.5
Classification: Unclassified
Component: File services
All Solaris
: P3 critical
: ---
Assigned To: Karolin Seeger
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2010-04-22 06:01 UTC by Ira Cooper
Modified: 2010-04-25 01:51 UTC (History)
0 users

See Also:

dptr_Close patch. (755 bytes, patch)
2010-04-22 06:02 UTC, Ira Cooper
no flags Details
git am fix for 3.5.x. (990 bytes, patch)
2010-04-23 13:27 UTC, Jeremy Allison
vl: review+
jra: review? (metze)

Note You need to log in before you can comment on or make changes to this bug.
Description Ira Cooper 2010-04-22 06:01:42 UTC
There is a bitmap leak in the current implementation of dptr_Close.  It doesn't actually "fix-up" the bitmap after deallocating the dptr.

This patch runs the dptr_Close operation through dptr_close_internal which seems to do all the same things, and in addition actually does the bitmap manipulations.

Comment 1 Ira Cooper 2010-04-22 06:02:38 UTC
Created attachment 5648 [details]
dptr_Close patch.
Comment 2 Jeremy Allison 2010-04-23 13:01:15 UTC
Pushed - thanks ! This also needs to be in 3.5.x.
Comment 3 Jeremy Allison 2010-04-23 13:27:27 UTC
Created attachment 5651 [details]
git am fix for 3.5.x.
Comment 4 Jeremy Allison 2010-04-23 13:28:13 UTC
Comment on attachment 5651 [details]
git am fix for 3.5.x.

Metze, vl - please review for 3.5.next and reassign to Karolin. Looks obviously correct to me.


Comment 5 Karolin Seeger 2010-04-25 01:51:26 UTC
Pushed to v3-5-test.
Closing out bug report.