Bug 7378 - "net conf import" fails silently on parameter typo
"net conf import" fails silently on parameter typo
Status: RESOLVED FIXED
Product: Samba 3.4
Classification: Unclassified
Component: Config Files
3.4.3
Other Linux
: P3 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-20 15:45 UTC by Jim McDonough
Modified: 2010-04-21 13:55 UTC (History)
0 users

See Also:


Attachments
Patch for 3.4 (852 bytes, patch)
2010-04-20 15:48 UTC, Jim McDonough
lars: review-
Details
Patch for 3.5 (852 bytes, patch)
2010-04-20 15:48 UTC, Jim McDonough
lars: review-
Details
Updated patch for 3.4 with i18n support (875 bytes, patch)
2010-04-20 16:52 UTC, Jim McDonough
lars: review+
Details
Updated patch for 3.5 with i18n support (875 bytes, patch)
2010-04-20 16:53 UTC, Jim McDonough
lars: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McDonough 2010-04-20 15:45:00 UTC
When using "net conf import", a typo in a parameter name will fail silently (other than RC -1), leaving the user unaware that it has failed.
Comment 1 Jim McDonough 2010-04-20 15:48:19 UTC
Created attachment 5644 [details]
Patch for 3.4
Comment 2 Jim McDonough 2010-04-20 15:48:47 UTC
Created attachment 5645 [details]
Patch for 3.5
Comment 3 Jim McDonough 2010-04-20 15:50:11 UTC
Pushed a22f03e02c99c78642978c8e7a06ae92f97ad41f to master to display the
offending section name, parameter name, and windows error.


Patches attached for 3.4 and 3.5

Karolin, can we include these pending review?
Comment 4 Jeremy Allison 2010-04-20 16:10:21 UTC
+1 from me - obvious goodness. Re-assigning to Karolin for inclusion.
Jeremy.
Comment 5 Lars Müller 2010-04-20 16:37:41 UTC
Comment on attachment 5644 [details]
Patch for 3.4

Patch needs to use _() functions as stressed by Günther.
Comment 6 Lars Müller 2010-04-20 16:38:00 UTC
Comment on attachment 5645 [details]
Patch for 3.5

Patch needs to use _() functions as stressed by Günther.
Comment 7 Jim McDonough 2010-04-20 16:52:16 UTC
Created attachment 5646 [details]
Updated patch for 3.4 with i18n support
Comment 8 Jim McDonough 2010-04-20 16:53:08 UTC
Created attachment 5647 [details]
Updated patch for 3.5 with i18n support
Comment 9 Jim McDonough 2010-04-21 08:32:31 UTC
Comment on attachment 5644 [details]
Patch for 3.4

The original 3.4 patch was correct.  No i18n done yet.  Bad Jim.  No treat for you...
Comment 10 Karolin Seeger 2010-04-21 13:55:29 UTC
Pushed to v3-5-test and v3-4-test.
Closing out bug report.

Thanks!