Bug 7352 - TIME_T_MAX defines inconsistent
Summary: TIME_T_MAX defines inconsistent
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.5.1
Hardware: Other Linux
: P3 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-12 05:57 UTC by Stefan Metzmacher
Modified: 2010-04-12 09:05 UTC (History)
3 users (show)

See Also:

Attachments
Patches for v3-5 (2.53 KB, patch)
2010-04-12 06:02 UTC, Stefan Metzmacher 		vl: review+
Details
Patches for v3-4 (2.53 KB, patch)
2010-04-12 06:34 UTC, Stefan Metzmacher 		vl: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2010-04-12 05:57:44 UTC 
We have two different definitions of TIME_T_MAX one in
lib/util/time.c and one in source3/lib/time.c.

On 64bit machines one is INT32_MAX and the other INT64_MAX,
while both are used in the same build.

This results in all sorts of really ugly problems...

The problem is already fixed in master, but not in the production branches.
Comment 1 Stefan Metzmacher 2010-04-12 06:02:37 UTC 
Created attachment 5623 [details]
Patches for v3-5
Comment 2 Stefan Metzmacher 2010-04-12 06:34:52 UTC 
Created attachment 5624 [details]
Patches for v3-4
Comment 3 Karolin Seeger 2010-04-12 09:05:40 UTC 
Pushed to v3-5-test and v3-4-test.
Closing out bug report.

Thanks!