The header file libsmbclient.h (which is ostensibly the entirety of the API documentation) has some missing fields. The return values for smbc_fstat(), smbc_statvfs(), smbc_fstatvfs(), and smbc_ftruncate() don't enumerate success values. Presumably the line: @return 0 on success, < 0 on error with errno set: is missing. smbc_urldecode() also seems to be incorrect. Lastly, smbc_read() doesn't state what its return value is on End-of-File.
Thanks for the report. Please elaborate on what seems incorrect about smbc_urldecode(). I'll fix the others. Derrell
(In reply to comment #1) > Thanks for the report. Please elaborate on what seems incorrect about > smbc_urldecode(). I'll fix the others. > > Derrell Went back and looked again, but couldn't find what it was. So let's skip it for now, and if I find it again I'll either reopen the bug or file a new one.
Created attachment 5625 [details] patch for v3-5-test
Comment on attachment 5625 [details] patch for v3-5-test Looks good to me.
Re-assigning to Karolin for inclusion in 3.5.x. Jeremy.
Pushed to v3-5-test. Patch applies to v3-4-test also and the bug was reported against 3.4.5. Derrell, shall I pick this one for v3-4-test also?
Yes. I just confirmed that it applies cleanly (with an 11-line offset). No reason not to apply it there too. Thanks. Derrell
reassign back to Karolin
Pushed to v3-4-test also. Closing out bug report. Thanks!