Bug 7313 - Net conf addshare is not atomic
Summary: Net conf addshare is not atomic
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: Client Tools (show other bugs)
Version: 3.5.1
Hardware: Other Linux
: P3 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-31 10:24 UTC by Michael Adam
Modified: 2010-03-31 11:03 UTC (History)
0 users

See Also:

Attachments
Fix from master. (2.60 KB, patch)
2010-03-31 10:26 UTC, Michael Adam 		vl: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adam 2010-03-31 10:24:10 UTC 
When net conf addshare is interrupted, it can leave an incomplete share definition in the registry.
Comment 1 Michael Adam 2010-03-31 10:25:22 UTC 
reason is that net conf addshare is not protected by a transaction.
Comment 2 Michael Adam 2010-03-31 10:26:23 UTC 
Created attachment 5582 [details]
Fix from master.

This fixes the bug by adding a transaction around net conf addshare.
Comment 3 Karolin Seeger 2010-03-31 11:03:56 UTC 
Pushed to v3-5-test.
Closing out bug report.

Thanks!