Bug 7312 - Many disconnecting clients renders clustered samba unusuable for some time
Many disconnecting clients renders clustered samba unusuable for some time
Status: RESOLVED FIXED
Product: Samba 3.5
Classification: Unclassified
Component: File services
3.5.1
All Linux
: P3 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-03-31 09:46 UTC by Michael Adam
Modified: 2010-03-31 10:57 UTC (History)
2 users (show)

See Also:


Attachments
Patches by Tridge that fix this bug. (9.33 KB, patch)
2010-03-31 09:54 UTC, Michael Adam
metze: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adam 2010-03-31 09:46:05 UTC
When we are waiting on a pending byte range lock, another smbd might
exit uncleanly, and therefore not notify us of the removal of the
lock, and thus not trigger the lock to be retried.
  
We currently cope with this by adding a message_send_all() in the
SIGCHLD and cluster reconfigure handlers to send a MSG_SMB_UNLOCK to
all smbd processes. That generates O(N^2) work when a large
number of clients disconnected at once (such as on a network outage),
which can leave the whole system unusable for a very long time (many
minutes, or even longer).
Comment 1 Michael Adam 2010-03-31 09:54:19 UTC
Created attachment 5580 [details]
Patches by Tridge that fix this bug.

This is a set of patches by Tridge that have
already gont into master and the clustered samba branches
that fix the problem by replacing the sending of all
a UNLOCK message to all smbd processes at unclean shutdown
with a regular cleanup.
Comment 2 Stefan Metzmacher 2010-03-31 10:26:38 UTC
Comment on attachment 5580 [details]
Patches by Tridge that fix this bug.

Looks good
Comment 3 Karolin Seeger 2010-03-31 10:57:33 UTC
Pushed to v3-5-test.
Closing out bug report.

Thanks!