Bug 7311 - Enable building of python modules (e.g. for provision) during merged-build (aka Franky)
Summary: Enable building of python modules (e.g. for provision) during merged-build (a...
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.6
Classification: Unclassified
Component: Build environment (show other bugs)
Version: unspecified
Hardware: x64 Linux
: P3 normal
Target Milestone: ---
Assignee: Jelmer Vernooij
QA Contact: samba4-qa@samba.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-31 05:37 UTC by Torsten Kurbad
Modified: 2012-02-23 11:56 UTC (History)
0 users

See Also:

Attachments
pythonmods.patch (1.62 KB, patch)
2010-03-31 05:38 UTC, Torsten Kurbad 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Kurbad 2010-03-31 05:37:44 UTC 
When trying to build Franky, i.e. configuring with '--enable-merged-build' from source3, I realized that the s4 Python modules, necessary for provision are neither built nor installed.

A comment in source3/samba4.mk says that building pythonmods had issues.

These are easily solved by the attached patch. The problem was that during link stage, -lpythonX.Y needs to be added as last argument to the linker. After doing so, everything compiles fine for recent git.

Best regards,
Torsten
Comment 1 Torsten Kurbad 2010-03-31 05:38:35 UTC 
Created attachment 5575 [details]
pythonmods.patch
Comment 2 Jelmer Vernooij 2010-03-31 19:38:23 UTC 
Thanks for the patch. 

This adds unnecessary changes to Samba 4, which already takes care of linking against the proper version of Python. 

We should either include a separate copy of build/make/python.mk in Samba 3 but preferably fix the merged build to include -lpython properly.
Comment 3 Matthias Dieter Wallnöfer 2012-02-23 08:22:26 UTC 
Jelmer, isn't this superflous with the merged WAF build system? Couldn't we close this bug?
Comment 4 Jelmer Vernooij 2012-02-23 11:56:32 UTC 
The combined build now installs both.