Samba-3.4.2 and later permits startup of smbd and nmbd when the "workgroup" name is the same as the "netbios name". Testparm no longer throws this situation as an error condition.
Can someone confirm if this is a reversion? I recall that this was previously addressed and we agreed that in such situation the Samba daemons should not start and should report in the logs a clear error message.
To validate, create the following smb.conf file:
workgroup = GEORGE
netbios name = GEORGE
Then run testparm, and start nmbd and smbd - both start without error message to the log files at default log level.
Created attachment 5531 [details]
Proposed patch to add testparm warning
Did testparm ever throw a warning about this one before?
I tried Samba 3.0.34 and it did not in this version.
I am not sure whether the daemons should start or not.
Raising product as this won't be fixed in 3.4.
(In reply to comment #1)
> Created an attachment (id=5531) [details]
> Proposed patch to add testparm warning
Pushed to master branch (after talking to Volker).
(In reply to comment #2)
> Did testparm ever throw a warning about this one before?
> I tried Samba 3.0.34 and it did not in this version.
> I am not sure whether the daemons should start or not.
I would advise NOT allowing smbd and nmbd to start. Under MS Windows, if the WORKGROUP and MACHINE name are the same, neither the workstation service and the server service will not start. I believe we should do the same.
Why break existing setups?
(In reply to comment #6)
> Why break existing setups?
Why break systems that work -or- that do NOT work?
Never break anything that works!
- John T.
I think a level 0 warning should be enough.
I think we should add that directly into loadparm.c,
so that the deamon logs also get it at startup.