Bug 7256 - incorrect value-needed calculation in _spoolss_EnumPrinterData()
Summary: incorrect value-needed calculation in _spoolss_EnumPrinterData()
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: Printing (show other bugs)
Version: 3.5.0
Hardware: Other Linux
: P3 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-16 04:56 UTC by Guenther Deschner
Modified: 2010-03-16 05:12 UTC (History)
0 users

See Also:

Attachments
patch for 3.5 (890 bytes, patch)
2010-03-16 04:57 UTC, Guenther Deschner 		metze: review+
gd: review? (jra)
 Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guenther Deschner 2010-03-16 04:56:39 UTC 
We incorrectly calculate the value-needed value in in _spoolss_EnumPrinterData() replies.

This value can impact the buffer allocation on windows clients, potentially causing the client to have too short value names.
Comment 1 Guenther Deschner 2010-03-16 04:57:45 UTC 
Created attachment 5504 [details]
patch for 3.5
Comment 2 Stefan Metzmacher 2010-03-16 05:03:28 UTC 
Comment on attachment 5504 [details]
patch for 3.5

Looks good
Comment 3 Stefan Metzmacher 2010-03-16 05:03:52 UTC 
Karolin, please pick for the next release
Comment 4 Karolin Seeger 2010-03-16 05:06:57 UTC 
Pushed to v3-5-test.
Closing out bug report.

Thanks!
Comment 5 Karolin Seeger 2010-03-16 05:12:33 UTC 
Cherry-picked to v3-4-test also.