Bug 7251 - Segfault in DEBUG(2,("waiting for connections...
Summary: Segfault in DEBUG(2,("waiting for connections...
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: File services (show other bugs)
Version: 3.5.1
Hardware: Other Linux
: P3 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-15 09:14 UTC by Stefan Metzmacher
Modified: 2010-03-15 10:06 UTC (History)
1 user (show)

See Also:

Attachments
Patch for v3-5 (2.93 KB, patch)
2010-03-15 09:16 UTC, Stefan Metzmacher 		obnox: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2010-03-15 09:14:27 UTC 
In smbd there's a small gab between TALLOC_FREE(frame); before
we call smbd_parent_loop() where we don't have a valid talloc stackframe.
    
smbd_parent_loop() calls talloc_stackframe() only within the while(1) loop.
As DEBUG(2,("waiting for connections")) uses talloc_tos() to construct
the time header for the debug message we crash on some systems.
Comment 1 Stefan Metzmacher 2010-03-15 09:16:34 UTC 
Created attachment 5499 [details]
Patch for v3-5
Comment 2 Michael Adam 2010-03-15 09:44:41 UTC 
Comment on attachment 5499 [details]
Patch for v3-5

ack
Comment 3 Michael Adam 2010-03-15 09:57:07 UTC 
assign bug to karolin for incusion in 3.5.2
Comment 4 Karolin Seeger 2010-03-15 10:06:52 UTC 
Pushed to v3-5-test.
Closing out bug report.

Metze, thanks a lot for tracking this one down! :-)