Bug 7231 - vfs_tsmsm not built automatically
vfs_tsmsm not built automatically
Product: Samba 3.4
Classification: Unclassified
Component: VFS Modules
Other Linux
: P3 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2010-03-10 04:39 UTC by Michael Adam
Modified: 2010-03-11 03:17 UTC (History)
0 users

See Also:

Patch for 3.4 and for 3.5. (903 bytes, patch)
2010-03-10 04:42 UTC, Michael Adam
metze: review+

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adam 2010-03-10 04:39:30 UTC
When gpfs and libmapi are found by configure, the tsmsm vfs module should be built automatically. In commit b71f0e5f6f715d7c061d3a845f1e983e2472c1b0 (in v3-4-test), the check for gpfs was simplified and the variable samba_cv_HAVE_GPFS was removed. But the check for building tsmsm still relies on that variable so the patch broke the automatic building of vfs_tsmsm.
Comment 1 Michael Adam 2010-03-10 04:42:45 UTC
Created attachment 5481 [details]
Patch for 3.4 and for 3.5.

This patch fixes the bug.
It applies to 3.4 and 3.5. We should pick it for both releases.

It has already been pushed as 9113e14b291c10c824d2d8ea5cb28ffc0adcb63b to master.
Comment 2 Stefan Metzmacher 2010-03-10 05:42:09 UTC
Comment on attachment 5481 [details]
Patch for 3.4 and for 3.5.

Looks good
Comment 3 Karolin Seeger 2010-03-11 03:17:35 UTC
Pushed to v3-5-test and v3-4-test.
Closing out bug report.