i'm using wins for resolving host names in local network, after upgrading to samba 3.5.0 applications crashes when using wins to resolving host names.
Created attachment 5444 [details] strace of ping command strace says "No such file or directory", but this file exists and readable by everybody ---- stat64("/etc/samba/smb.conf", 0xbfbff680) = -1 ENOENT (No such file or directory) open("/etc/samba/smb.conf", O_RDONLY|O_LARGEFILE) = -1 ENOENT (No such file or directory) ---- > ls -l /etc/samba/smb.conf -rw-r--r-- 1 root root 9686 Mar 3 11:29 /etc/samba/smb.conf
Created attachment 5445 [details] another one strace seems like in previous strace log smb.conf don't exists, here it is, but with it nothing changes
Nothing has changed in libsmbclient to have affected this. To Jeremy, and component -> File Services.
Created attachment 5511 [details] Patch The attached patch fixes it for me. Can you try that? Thanks, Volker
yes, patch from Volker fixes this
Thanks for testing! Reopening the bug, Karolin needs to merge it to v3-5-test after another developer (metze) has reviewed it. Volker
The patch fixes the issue for me.
firefox and ping stop crashing after this patch, but chromium and sonata still crash
Any chance to run them under valgrind --tool=memcheck and send the output? Volker
Created attachment 5513 [details] Backtrace of Chromium crash
Created attachment 5514 [details] Backtrace of Chromium crash 2
Created attachment 5516 [details] valgrind --tool=memcheck of Chromium crash
Quick question: Is it possible that you compiled Samba on a box without pthread headers? Can you grep for HAVE_PTHREAD in include/config.h ? Thanks, Volker
(In reply to comment #13) > Quick question: Is it possible that you compiled Samba on a box without pthread > headers? Can you grep for HAVE_PTHREAD in include/config.h ? > > Thanks, > > Volker > You asked me or Jonathan? :) my grep: #define HAVE_PTHREAD_H 1 also, do you need another one output of valgrind --memtool=check?
Hmm. You only have HAVE_PTHREAD_H and not HAVE_PTHREAD? That would be bad... Looking at it, it seems that our PTHREAD detection is broken. I don't have a fix handy, but to make sure this would fix the chromium crash, can you insert a #define HAVE_PTHREAD 1 into include/config.h after you ran ./configure and before you run make? If this fixes the chromium chrash, this would help me debugging it. Thanks, Volker
(In reply to comment #15) > Hmm. You only have HAVE_PTHREAD_H and not HAVE_PTHREAD? That would be bad... > > Looking at it, it seems that our PTHREAD detection is broken. I don't have a > fix handy, but to make sure this would fix the chromium crash, can you insert a > > #define HAVE_PTHREAD 1 > > into include/config.h after you ran ./configure and before you run make? If > this fixes the chromium chrash, this would help me debugging it. > > Thanks, > > Volker > after i manually add "#define HAVE_PTHREAD 1" into include/config.h chromium and sonata stops crashing
Great, thanks! Expect a patch soon. Volker
Created attachment 5522 [details] Patch This patch should fix this bug for multi-threaded apps as well. Thanks! Volker
Comment on attachment 5511 [details] Patch Looks good
Comment on attachment 5522 [details] Patch Looks good
Karolin, please add both patches https://bugzilla.samba.org/attachment.cgi?id=5511 https://bugzilla.samba.org/attachment.cgi?id=5522 to v3-5-test. Thanks, Volker
(In reply to comment #21) > Karolin, please add both patches > > https://bugzilla.samba.org/attachment.cgi?id=5511 > https://bugzilla.samba.org/attachment.cgi?id=5522 > > to v3-5-test. > > Thanks, > > Volker > Pushed both patches to v3-5-test. Need to check whether it's an issue in 3.4 or not before closing.
Does not seem to be broken in 3.4. Closing out bug report. Thanks!