Bug 7196 - Build fails on SLES 8 (e.g.)
Summary: Build fails on SLES 8 (e.g.)
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.5.0
Hardware: Other Linux
: P3 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-02 04:59 UTC by Karolin Seeger
Modified: 2010-05-11 07:54 UTC (History)
0 users

See Also:


Attachments
Patch for v3-5 (3.75 KB, patch)
2010-04-26 02:50 UTC, Stefan Metzmacher
metze: review? (jra)
gd: review+
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karolin Seeger 2010-03-02 04:59:31 UTC
Compiling ../lib/tsocket/tsocket_bsd.c
../lib/tsocket/tsocket_bsd.c: In function `tdgram_bsd_dgram_socket':
../lib/tsocket/tsocket_bsd.c:1249: `IPV6_V6ONLY' undeclared (first use in this function)
../lib/tsocket/tsocket_bsd.c:1249: (Each undeclared identifier is reported only once
../lib/tsocket/tsocket_bsd.c:1249: for each function it appears in.)
../lib/tsocket/tsocket_bsd.c: In function `tstream_bsd_connect_send':
../lib/tsocket/tsocket_bsd.c:2090: `IPV6_V6ONLY' undeclared (first use in this function)
The following command failed:
gcc -I../lib/zlib -I/usr/src/packages/BUILD/heimdal-0.7.2-inst/include -O1 -D_GNU_SOURCE -D_LARGEFILE64_SOURCE -g -I/usr/src/packages/BUILD/heimdal-0.7.2-inst/include -I. -I/usr/src/packages/BUILD/samba-3.5.
0/source3 -I/usr/src/packages/BUILD/samba-3.5.0/source3/iniparser/src -Iinclude -I./include  -I. -I. -I./../lib/replace -I./../lib/tevent -I./libaddns -I./librpc -I./.. -I./../lib/talloc -I../lib/tdb/include
 -DHAVE_CONFIG_H  -I/usr/src/packages/BUILD/heimdal-0.7.2-inst/include -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -Iinclude -I./include -I. -I. -I./../lib/replace -I./../lib/tevent -I./libadd
ns -I./librpc -I./.. -I./../lib/popt -DLDAP_DEPRECATED  -I/usr/src/packages/BUILD/samba-3.5.0/source3/lib -I.. -I../source4 -D_SAMBA_BUILD_=3 -D_SAMBA_BUILD_=3  -fPIC -c ../lib/tsocket/tsocket_bsd.c -o ../li
b/tsocket/tsocket_bsd.o
make: *** [../lib/tsocket/tsocket_bsd.o] Error 1
Comment 1 Stefan Metzmacher 2010-04-26 02:46:45 UTC
We rely on IPV6_V6ONLY being support, because
some system already have this as default. It's easier
to behave the same way on all systems and handle ipv6
and ipv4 sockets separate.
Comment 2 Stefan Metzmacher 2010-04-26 02:49:56 UTC
This is also related to bug 7140
Comment 3 Stefan Metzmacher 2010-04-26 02:50:24 UTC
Created attachment 5657 [details]
Patch for v3-5
Comment 4 Stefan Metzmacher 2010-05-10 06:01:41 UTC
Comment on attachment 5657 [details]
Patch for v3-5

Jeremy, can you please review this, so that we can include it in the next release?
Comment 5 Guenther Deschner 2010-05-10 08:30:43 UTC
Comment on attachment 5657 [details]
Patch for v3-5

Fix looks all right but I cannot really test it here.
Comment 6 Stefan Metzmacher 2010-05-11 07:09:49 UTC
Karolin, please pick for the release
Comment 7 Karolin Seeger 2010-05-11 07:54:05 UTC
Pushed to v3-5-test.
Closing out bug report.

Thanks!