Bug 7177 - wrong error code when no stream support available
wrong error code when no stream support available
Status: NEW
Product: Samba 4.0
Classification: Unclassified
Component: File services
4.0.0rc1
Other All
: P3 major
: ---
Assigned To: Samba QA Contact
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-02-25 05:45 UTC by Björn Jacke
Modified: 2012-11-07 11:49 UTC (History)
2 users (show)

See Also:


Attachments
sniff of a XP client requesting stream info of a file where streams are not supported (on FAT) (48.87 KB, application/octet-stream)
2010-02-25 05:47 UTC, Björn Jacke
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2010-02-25 05:45:33 UTC
on QUERY_PATH_INFO we need to reply with STATUS_OBJECT_NAME_INVALID. An XP workstation gives that back when a client requests the Zone.Identifier information of a file that is located on a FAT volume. Currently we reply STATUS_OBJECT_PATH_NOT_FOUND when we have no stream vfs module loaded. As a result an XP client thinks we *do* support streams and the property dialog allowes a user to modify "fileinfo" tab but saving them fails. Here's the relevant smbd log:

[2010/02/25 12:28:27.075171,  3] smbd/trans2.c:5083(call_trans2qfilepathinfo)
  call_trans2qfilepathinfo: TRANSACT2_QPATHINFO: level = 1004
[2010/02/25 12:28:27.075202,  5] smbd/filename.c:169(unix_convert)
  unix_convert called on file "Neu Textdokument.txt:Zone.Identifier"
[2010/02/25 12:28:27.075230, 10] smbd/statcache.c:275(stat_cache_lookup)
  stat_cache_lookup: lookup succeeded for name [NEU TEXTDOKUMENT.TXT]
-> [Neu Textdokument.txt]
[2010/02/25 12:28:27.075264, 10] smbd/filename.c:1062(build_stream_path)
  comparing [:Zone.Identifier] and [::$DATA]: not equal
[2010/02/25 12:28:27.075288,  3] smbd/vfs.c:851(check_reduced_name)
  check_reduced_name [Neu Textdokument.txt] [/storage/disk1]
[2010/02/25 12:28:27.075325, 10] smbd/vfs.c:938(check_reduced_name)
  check_reduced_name realpath [Neu Textdokument.txt] ->
[/storage/disk1/Neu Textdokument.txt]
[2010/02/25 12:28:27.075349,  3] smbd/vfs.c:1008(check_reduced_name)
  check_reduced_name: Neu Textdokument.txt reduced to
/storage/disk1/Neu Textdokument.txt
[2010/02/25 12:28:27.075372,  3] smbd/trans2.c:5192(call_trans2qfilepathinfo)
  call_trans2qfilepathinfo: SMB_VFS_STAT of Neu
Textdokument.txt:Zone.Identifier failed (No such file or directory)
[2010/02/25 12:28:27.075414,  3] smbd/error.c:80(error_packet_set)
  error packet at smbd/trans2.c(5194) cmd=50 (SMBtrans2)
NT_STATUS_OBJECT_NAME_NOT_FOUND

When the client gets STATUS_OBJECT_NAME_INVALID the "fileinfo" tab does not show up.
Comment 1 Björn Jacke 2010-02-25 05:47:08 UTC
Created attachment 5421 [details]
sniff of a XP client requesting stream info of a file where streams are not supported (on FAT)
Comment 2 Björn Jacke 2010-02-25 05:48:18 UTC
the sniff is for reference (XP agains XP)
Comment 3 Björn Jacke 2010-03-18 06:06:27 UTC
is there a chance to get this fixed for 3.5.2 ?
Comment 4 Guenther Deschner 2010-05-27 04:51:28 UTC
Volker, can this be fixed ?
Comment 5 Björn Jacke 2010-07-16 04:08:55 UTC
Jeremy, do you have the time to look into fixing this?