Bug 7160 - rpccli_netlogon_set_trust_password() fails against 3.4.x
Summary: rpccli_netlogon_set_trust_password() fails against 3.4.x
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: Winbind (show other bugs)
Version: 3.5.0rc3
Hardware: Other Linux
: P3 regression
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-19 16:37 UTC by Stefan Metzmacher
Modified: 2010-02-24 02:39 UTC (History)
1 user (show)

See Also:

Attachments
Patch for v3-5 and master (1.78 KB, patch)
2010-02-19 16:39 UTC, Stefan Metzmacher 		gd: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Metzmacher 2010-02-19 16:37:11 UTC 
rpccli_netlogon_setup_creds doesn't negotiate the negotiate_flags
if the server supports strong keys, but doesn't support NETLOGON_NEG_PASSWORD_SET2
like samba <= 3.4.x
Comment 1 Stefan Metzmacher 2010-02-19 16:39:10 UTC 
Created attachment 5400 [details]
Patch for v3-5 and master

Günther,

does that look correct?

metze
Comment 2 Karolin Seeger 2010-02-23 04:12:16 UTC 
Raising severity as this is a regression.
Comment 3 Stefan Metzmacher 2010-02-23 04:14:22 UTC 
Björn, can you please test this patch?
Comment 4 Björn Jacke 2010-02-23 06:18:09 UTC 
a 3.5 member server can now successfully change it's machine account password on a 3.4.6 PDC.

+1
Comment 5 Stefan Metzmacher 2010-02-23 06:29:52 UTC 
Thanks!

Does it also works against a 3.5.0 dc with ServerPasswordSet2()?
Comment 6 Björn Jacke 2010-02-23 06:33:50 UTC 
I don't have that at hand, maybe someone else can confirm that?
Comment 7 Guenther Deschner 2010-02-23 08:46:46 UTC 
Comment on attachment 5400 [details]
Patch for v3-5 and master

yes, looks ok.
Comment 8 Stefan Metzmacher 2010-02-23 09:24:01 UTC 
Karolin please cherry pick 1e9df26ef970df41de54142a78606a15374acbac
it has the bug number in it
Comment 9 Karolin Seeger 2010-02-24 02:39:17 UTC 
Pushed to v3-5-test.
Closing out bug report.

Thanks!