Bug 7154 - mangling method = hash can crash storing a name not containing a '.'
Summary: mangling method = hash can crash storing a name not containing a '.'
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: File services (show other bugs)
Version: 3.5.0pre2
Hardware: All All
: P3 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-18 13:27 UTC by Jeremy Allison
Modified: 2010-02-19 02:24 UTC (History)
0 users

See Also:

Attachments
git-am patch for 3.5.0rc3 (1.31 KB, patch)
2010-02-18 13:30 UTC, Jeremy Allison 		gd: review+
Details
git-am patch for 3.4.6. (1.31 KB, patch)
2010-02-18 13:32 UTC, Jeremy Allison 		gd: review+
Details
git-am patch for 3.3.11. (1.31 KB, patch)
2010-02-18 13:34 UTC, Jeremy Allison 		gd: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2010-02-18 13:27:03 UTC 
An uninitialized variable can lead to a write of random data into memory if smb.conf has :

mangling method = hash

and we're caching a 8 character or less name not containing a '.'.

Patch to follow.

Jeremy.
Comment 1 Jeremy Allison 2010-02-18 13:30:31 UTC 
Created attachment 5383 [details]
git-am patch for 3.5.0rc3
Comment 2 Jeremy Allison 2010-02-18 13:32:03 UTC 
Created attachment 5384 [details]
git-am patch for 3.4.6.
Comment 3 Jeremy Allison 2010-02-18 13:34:04 UTC 
Created attachment 5385 [details]
git-am patch for 3.3.11.

Guenther - please re-assign to Karolin for inclusion in rc3 (and other branches) once you've reviewed.

Thanks !

Jeremy.
Comment 4 Guenther Deschner 2010-02-18 13:42:12 UTC 
Comment on attachment 5383 [details]
git-am patch for 3.5.0rc3

looks fine
Comment 5 Guenther Deschner 2010-02-18 13:43:30 UTC 
Karolin, please add to v3-5,v3-4 and v3-3.

Thanks
Comment 6 Karolin Seeger 2010-02-19 02:24:03 UTC 
Pushed to all branches.
Closing out bug report.

Thanks!