Bug 7148 - vfs_acl_tdb module uses uninitialized variable. Reading blob can fail.
Summary: vfs_acl_tdb module uses uninitialized variable. Reading blob can fail.
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.5
Classification: Unclassified
Component: File services (show other bugs)
Version: 3.5.0rc2
Hardware: All All
: P3 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-17 21:46 UTC by Jeremy Allison
Modified: 2010-02-18 04:19 UTC (History)
0 users

See Also:

Attachments
git-am patch for 3.5.0rc3 (897 bytes, patch)
2010-02-17 21:50 UTC, Jeremy Allison 		gd: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2010-02-17 21:46:03 UTC 
As discovered by Guenther, modules/vfs_acl_tdb.c can test against an uninitialized variable for an NT_STATUS_OK test. Must have always been zero on my testing.

Patch to follow.

Jeremy.
Comment 1 Jeremy Allison 2010-02-17 21:50:36 UTC 
Created attachment 5373 [details]
git-am patch for 3.5.0rc3

Guenther please review this and re-assign to Karolin for inclusion.
Thanks,
Jeremy.
Comment 2 Guenther Deschner 2010-02-18 04:01:48 UTC 
Comment on attachment 5373 [details]
git-am patch for 3.5.0rc3

yep, patch looks good :-)
Comment 3 Guenther Deschner 2010-02-18 04:02:19 UTC 
Karolin, please add to v3-5-test (at least)
Comment 4 Karolin Seeger 2010-02-18 04:16:57 UTC 
Pushed to v3-5-test.
Re-assigning to Günther to verify which other versions are affected.
Comment 5 Guenther Deschner 2010-02-18 04:17:53 UTC 
well, only to v3-5-test.
Comment 6 Guenther Deschner 2010-02-18 04:19:01 UTC 
Thanks Karolin (patch is in 3.5 now).