Bug 7110 - Symlink fake-super data is silently lost when sys_lsetxattr fails with EPERM
Summary: Symlink fake-super data is silently lost when sys_lsetxattr fails with EPERM
Status: NEW
Alias: None
Product: rsync
Classification: Unclassified
Component: core (show other bugs)
Version: 3.1.0
Hardware: All All
: P3 major (vote)
Target Milestone: ---
Assignee: Wayne Davison
QA Contact: Rsync QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-07 19:05 UTC by Matt McCutchen
Modified: 2011-06-18 19:01 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt McCutchen 2010-02-07 19:05:12 UTC 
The summary says it all.  NO_SYMLINK_XATTRS is supposed to be defined on systems that don't allow xattrs on symlinks, but if this is forgotten (bug 7109), data may be lost.
Comment 1 Matt McCutchen 2011-06-18 19:01:59 UTC 
Specifically, I propose that the code in xattrs.c that swallows EPERM for symlinks be removed as explained in bug 7109 comment 4.