The Samba-Bugzilla – Bug 7075
bug in vfs_scannedonly rmdir implementation
Last modified: 2010-03-24 04:19:04 UTC
the rmdir implementation in vfs_scannedonly calles NEXT_CLOSEDIR instead of NEXT_RMDIR. Will attach a patch.
Created attachment 5246 [details]
patch against git 3.5-stable
Created attachment 5276 [details]
git-am patch for 3.5.0
I think this is correct, your patch still called CLOSEDIR not RMDIR. Once you confirm I'll re-assign to Karolin for inclusion in 3.5.0.
that patch looks better indeed.
One thing that I am not sure about: could there be a situation where opendir() would return NULL, but rmmdir() would be succesfull?
In that case you should not return -1 if opendir() fails, but return SMB_VFS_NEXT_RMDIR(handle, path);
(if the directory is 100% empty, rmmdir will succeed)
several other people have contacted me because of this issue in rmmdir. Why is the patch not yet applied? Is there something I can do?
Re-assigning to Karolin for inclusion in 3.5.2.
Confirmed by author.
Loooks good, please include it in v3-5-test
Pushed to v3-5-test.
Closing out bug report.