Bug 7033 - SMBrmdir call always returns true, even on failure to delete a directory.
SMBrmdir call always returns true, even on failure to delete a directory.
Product: Samba 3.5
Classification: Unclassified
Component: File services
Other Linux
: P3 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2010-01-12 18:50 UTC by Jeremy Allison
Modified: 2010-01-14 08:14 UTC (History)
0 users

See Also:

git-am patch for 3.5.0. (2.34 KB, patch)
2010-01-13 16:38 UTC, Jeremy Allison
metze: review+
git-am patch for 3.5.0. (2.34 KB, patch)
2010-01-14 00:15 UTC, Jeremy Allison
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2010-01-12 18:50:39 UTC
There is a codepath missing to propagate back error returns from the rmdir POSIX call inside close_directory when delete on close is set. This means doing an rmdir on a Windows command line will always report success, even when the directory was not deleted.

Comment 1 Jeremy Allison 2010-01-13 16:38:55 UTC
Created attachment 5170 [details]
git-am patch for 3.5.0.

This bug only affects 3.5.0.
Comment 2 Jeremy Allison 2010-01-13 16:40:07 UTC
Comment on attachment 5170 [details]
git-am patch for 3.5.0.

Requesting reviews from Metze and Michael as I know how busy Volker is. Once this is ok'ed I'll assign to Karolin for inclusion in 3.5.0rc2.

Comment 3 Stefan Metzmacher 2010-01-13 19:20:57 UTC
Comment on attachment 5170 [details]
git-am patch for 3.5.0.

The commit message is wrong

commit 33ee8b5a4e390f9aa43cceeec137c0ed82171340
Author:     Jeremy Allison <jra@samba.org>
AuthorDate: Tue Jan 12 21:06:09 2010 -0800
Commit:     Jeremy Allison <jra@samba.org>
CommitDate: Tue Jan 12 21:06:09 2010 -0800

    Make file access control decisions a lot easier to debug (at level 10).

This is not part of the patch.

You mean 105f876eb447e6839b9b19c2

I don't see why
is needed for me it doesn't change the logic
Comment 4 Stefan Metzmacher 2010-01-13 19:23:01 UTC
Comment on attachment 5170 [details]
git-am patch for 3.5.0.

Ah, I got what 105f876eb447e6839b9b19c2d264c4a168cf0cc9 tries to do:-)

So please change the commit message, then I'm fine with the fix.
Comment 5 Stefan Metzmacher 2010-01-13 19:24:08 UTC
Karolin please change


in the commit message
Comment 6 Jeremy Allison 2010-01-14 00:15:27 UTC
Created attachment 5176 [details]
git-am patch for 3.5.0.

Fixed the patch to refer to the correct master git reference (pointed out by Volker - thanks !).
Comment 7 Jeremy Allison 2010-01-14 00:17:37 UTC
I meant "pointed out by Metze" in the previous message, not "pointed out by Volker". Thanks Metze !

Karolin please push to 3.5.0.

Comment 8 Michael Adam 2010-01-14 05:03:25 UTC
Gosh, I saw this too late - thanks to Metze for the review.
Guess I am kind of busy too, but please have me review patches
as well, there is no need to put all the burden onto Vollker
and you, Jeremy. :-)

Cheers - Michael
Comment 9 Karolin Seeger 2010-01-14 08:14:30 UTC
Pushed to v3-5-test.
Closing out bug report.