Last months I have been working (with lots of help from Volker) to improve the scannedonly VFS module code quality to merge it into the samba codebase.
Volker created a git patch to include the module:
Jeremy suggested to create a bugreport to include the module in Samba 3.5
Jeremy, I've pushed the module plus the GPLv3+ modification to master. If you also give it your ack, I think it can go to 3.5.
Ok, the only thing I think must be changed is the two uses of strncat() must be changed to strlcat() for security and safety reasons. I think the current use is actually ok, but I really don't want to encourage use of strncat in our codebase. If you don't get to it I will try and do so soon.
Olivier please test the version in master.
Created attachment 5171 [details]
git-am patch for 3.5.0 part 1
Created attachment 5172 [details]
git-am patch for 3.5.0 part 2
Created attachment 5173 [details]
git-am patch for 3.5.0 part 3
Olivier, please review these 3 patches asap (next 2 days or so). Once you've given them a positive review I'll re-assign this bug to Karolin for inclusion in the next 3.5.0 pre-release.
While testing all different cases I've found an issue and fixed it. Will upload the patch soon.
Created attachment 5178 [details]
Missing slash issue
Created attachment 5185 [details]
git-am patch for 3.5.0 part 4
Olivier, please review the 3.5.0 tree with all four parts of this patch applied and then respond to this bug report with an ok. Once you've done that I'll re-assign to Karolin for inclusion in 3.5.0.
this is when you need an automated test ;-)
but, after an hour of manual testing, every combination of settings seems to be working fine.
I did a clean git checkout to be sure (I'm not that familiar with git yet), and applied all 4 patches in the correct order.
so this an OK from me. thanks for your reviewing.
Ok, re-assigning to Karolin for inclusion in 3.5.0 now you've ok'ed the patches.
Pushed to v3-5-test. Will be included in 3.5.0rc2.
Olivier, could you please provide documentation for your module, please?
A good start would be to copy the documentation of another vfs module (docs-xml/manpages-3/vfs_*) and adapt it. You can just attach the new xml file to this bug report and I will test the build then.
Thanks a lot! :-)
Created attachment 5199 [details]
I hope the syntax is correct.
Perfectly fine, thanks! :-)
Pushed to master (3fb359aa56) and v3-5-test (a26389a222) after some cosmetic changes.
Closing out bug report.