Bug 7008 - vfs_recycle does not create empty directories
Summary: vfs_recycle does not create empty directories
Status: NEW
Alias: None
Product: Samba 4.1 and newer
Classification: Unclassified
Component: VFS Modules (show other bugs)
Version: 4.14.6
Hardware: All All
: P3 normal (vote)
Target Milestone: ---
Assignee: Samba QA Contact
QA Contact: Samba QA Contact
URL:
Keywords:
: 10109 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-12-24 01:45 UTC by Tsukasa HAMANO
Modified: 2021-08-11 19:39 UTC (History)
4 users (show)

See Also:

Attachments
patch for 3.2.x (2.55 KB, text/x-diff)
2009-12-24 02:01 UTC, Tsukasa HAMANO 		no flags Details
Patch for 3.4.x (2.56 KB, patch)
2009-12-25 11:24 UTC, Tsukasa HAMANO 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tsukasa HAMANO 2009-12-24 01:45:18 UTC 
vfs_recycle module does not create empty directory due to it handle only unlink hook.
I think it need to handle rmdir too.
Comment 1 Tsukasa HAMANO 2009-12-24 02:01:05 UTC 
Created attachment 5109 [details]
patch for 3.2.x

I implemented rmdir hook that can recycle empty dir.
Check it please.
Comment 2 Tsukasa HAMANO 2009-12-25 11:24:01 UTC 
Created attachment 5111 [details]
Patch for 3.4.x

Patch for 3.4.x
Comment 3 Karolin Seeger 2010-03-24 10:33:50 UTC 
Any volunteer for patch review?
Comment 4 Karolin Seeger 2010-04-08 04:26:09 UTC 
Is there a chance to get the patch reviewed before 3.4.8 (May 11)?
Comment 5 Björn Jacke 2021-08-11 19:39:50 UTC 
*** Bug 10109 has been marked as a duplicate of this bug. ***