I checked that 20bcdf85f1621 works fine and fixes the GetAliasMembership call with 0 rids. It should go into 3.4, too.
looks fine, w2k8 returns NULL though, does that mean w2k8 would crash an xp client ?
with this patch we behave like w2k3,win7,xp samr servers which I think is perfectly fine.
the attaches vbs script enumerates the users group memberships. This did not work with samba 3.4.3 from a w2k client. Adding the user to the builtin\users group helped. Adding "domain users" to builtin\users however triggered an access denied error. comparing the sniff of w2k->samba against w2k->nt4 showed up different answers in the getaliasmembership responses. With the change of this patch the script worked just fine from a w2k->samba.
Const ADS_READONLY_SERVER = 4
Set objNameSpace = GetObject( "WinNT:" )
Set objUser = objNameSpace.OpenDSObject("WinNT://" & "MYDOMAIN" & "/" & "testuser", "", "", ADS_READONLY_SERVER)
msgbox "strUserPasswordAge=" & objUser.Fullname
msgbox "strUserDescription=" & objUser.description
msgbox "strUserPasswordAge=" & objUser.PasswordAge
For Each objGroup In objUser.Groups
msgbox "User ist Mitglied in: " & objGroup.Name
Pushed, closing out bug report.