Bug 6997 - Fix _samr_GetAliasMembership for results with 0 rids
Fix _samr_GetAliasMembership for results with 0 rids
Product: Samba 3.4
Classification: Unclassified
Component: Domain Control
All All
: P3 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2009-12-17 04:34 UTC by Björn Jacke
Modified: 2009-12-18 08:53 UTC (History)
0 users

See Also:
vl: review+
gd: review+


Note You need to log in before you can comment on or make changes to this bug.
Description Björn Jacke 2009-12-17 04:34:40 UTC
I checked that 20bcdf85f1621 works fine and fixes the GetAliasMembership call with 0 rids. It should go into 3.4, too.
Comment 1 Guenther Deschner 2009-12-17 08:48:11 UTC
looks fine, w2k8 returns NULL though, does that mean w2k8 would crash an xp client ?

with this patch we behave like w2k3,win7,xp samr servers which I think is perfectly fine.
Comment 2 Björn Jacke 2009-12-17 09:27:33 UTC
additional information:

the attaches vbs script enumerates the users group memberships. This did not work with samba 3.4.3 from a w2k client. Adding the user to the builtin\users group helped. Adding "domain users" to builtin\users however triggered an access denied error. comparing the sniff of w2k->samba against w2k->nt4 showed up different answers in the getaliasmembership responses. With the change of this patch the script worked just fine from a w2k->samba.

Dim objNameSpace
Dim objUser
dim objGroup

Set objNameSpace = GetObject( "WinNT:" )
Set objUser = objNameSpace.OpenDSObject("WinNT://" & "MYDOMAIN" & "/" & "testuser", "", "", ADS_READONLY_SERVER)

msgbox "strUserPasswordAge=" & objUser.Fullname
msgbox "strUserDescription=" & objUser.description
msgbox "strUserPasswordAge=" & objUser.PasswordAge

For Each objGroup In objUser.Groups
msgbox "User ist Mitglied in: " & objGroup.Name
Comment 3 Karolin Seeger 2009-12-18 08:53:26 UTC
Pushed, closing out bug report.