Bug 6982 - Erroneous out of memory error path in lookup_sid
Summary: Erroneous out of memory error path in lookup_sid
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.4
Classification: Unclassified
Component: Winbind (show other bugs)
Version: 3.4.3
Hardware: Other Linux
: P3 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-10 00:58 UTC by Michael Adam
Modified: 2009-12-10 12:18 UTC (History)
0 users

See Also:

Attachments
Patch for 3.4 (909 bytes, patch)
2009-12-10 01:00 UTC, Michael Adam 		vl: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adam 2009-12-10 00:58:04 UTC 
In lsa_lookup_sids, a NULL domain name in a result leads to
an out of memory error message since talloc_strdup give a
NULL result string.

This is already fixed in master (and v3-5-test).
Comment 1 Michael Adam 2009-12-10 01:00:19 UTC 
Created attachment 5075 [details]
Patch for 3.4

This is the patch for 3.4.

Volker: Please review.
Well, you are the author of the patch, but please review for inclusion in 3.4.X

:)
Comment 2 Karolin Seeger 2009-12-10 02:32:35 UTC 
Pushed to v3-4-test.
Closing out bug report.

Thanks!
Comment 3 Guenther Deschner 2009-12-10 12:18:21 UTC 
Michael, do we have a torture test for this?