Bug 6934 - generated s3 pidl client did not deal with sizes correctly
generated s3 pidl client did not deal with sizes correctly
Status: RESOLVED FIXED
Product: Samba 3.4
Classification: Unclassified
Component: Build environment
3.4.0
Other Linux
: P3 normal
: ---
Assigned To: Karolin Seeger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-27 09:48 UTC by Guenther Deschner
Modified: 2009-11-30 08:37 UTC (History)
0 users

See Also:


Attachments
port of patch from master to v3-4-test (17.47 KB, patch)
2009-11-27 09:52 UTC, Guenther Deschner
metze: review+
Details
port of patch from master to v3-3-test (13.15 KB, patch)
2009-11-30 08:08 UTC, Guenther Deschner
gd: review? (metze)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Guenther Deschner 2009-11-27 09:48:35 UTC
pidl:Samba3/ClientNDR: $size can be 'foo / 2' so we need to add '(' and ')'
Comment 1 Guenther Deschner 2009-11-27 09:52:24 UTC
Created attachment 5018 [details]
port of patch from master to v3-4-test
Comment 2 Stefan Metzmacher 2009-11-30 07:36:05 UTC
Comment on attachment 5018 [details]
port of patch from master to v3-4-test

looks good
Comment 3 Guenther Deschner 2009-11-30 07:38:23 UTC
Karolin, please pick for v3-4-test and v3-3-test.
Comment 4 Karolin Seeger 2009-11-30 08:04:00 UTC
Pushed to v3-4-test.
Patch does not apply to v3-3-test.
Comment 5 Guenther Deschner 2009-11-30 08:08:12 UTC
Created attachment 5025 [details]
port of patch from master to v3-3-test

metze, please quickly look over it.
Comment 6 Guenther Deschner 2009-11-30 08:37:55 UTC
Ok, closing as fixed, as the patch for v3-3-test is strictly not needed (as the generated ndr code shows, nothing would change).