Bug 6932 - byte range lock requests greater than 64-bit do not return the proper error code
Summary: byte range lock requests greater than 64-bit do not return the proper error code
Status: CLOSED FIXED
Alias: None
Product: Samba 4.0
Classification: Unclassified
Component: File services (show other bugs)
Version: unspecified
Hardware: All Linux
: P3 normal (vote)
Target Milestone: ---
Assignee: Andrew Bartlett
QA Contact: samba4-qa@samba.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-26 23:27 UTC by Steven Danneman
Modified: 2009-11-27 02:43 UTC (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steven Danneman 2009-11-26 23:27:26 UTC 
In versions of Windows < Win7 a request for a byte range lock who's offset plus
length was greater than 64-bits would return NT_STATUS_OK.  Win7 introduced the
new error code STATUS_INVALID_LOCK_RANGE.

The Samba4 SMB server should check for range violations and now return this
error.  The RAW-LOCK-LOCKX, SMB2-LOCK-LOCK, and SMB2-LOCK-VALID-REQUEST tests
in smbtorture4 exercise this behavior.

Once this is fixed, these tests should also be removed from 
source4/selftest/knownfail
Comment 1 Andrew Tridgell 2009-11-27 02:43:37 UTC 
Thanks Steven! I've added the range tests to the code and updated the knownfail