Bug 6811 - pam_winbind references freed memory.
Summary: pam_winbind references freed memory.
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.4
Classification: Unclassified
Component: Winbind (show other bugs)
Version: unspecified
Hardware: Other Linux
: P3 normal
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-14 14:03 UTC by Jeremy Allison
Modified: 2009-10-15 07:31 UTC (History)
1 user (show)

See Also:

Attachments
git-am format patch for 3.4.3. (1.32 KB, patch)
2009-10-14 14:23 UTC, Jeremy Allison 		no flags Details
git-am format patch for 3.3.9. (1.36 KB, patch)
2009-10-14 14:29 UTC, Jeremy Allison 		no flags Details
git-am format patch for 3.4.3. (1.40 KB, patch)
2009-10-14 14:47 UTC, Jeremy Allison 		obnox: review+
Details
git-am format patch for 3.3.9. (1.43 KB, patch)
2009-10-14 14:50 UTC, Jeremy Allison 		obnox: review+
Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2009-10-14 14:03:28 UTC 
Found by boyang, the code in winbind_name_to_sid_string() frees memory and then references a pointer to the just freed value.

Bug exists in 3.4.x and 3.3.x.

Jeremy.
Comment 1 Jeremy Allison 2009-10-14 14:23:18 UTC 
Created attachment 4846 [details]
git-am format patch for 3.4.3.
Comment 2 Jeremy Allison 2009-10-14 14:29:13 UTC 
Created attachment 4847 [details]
git-am format patch for 3.3.9.

Same fix for 3.3.9.
Jeremy.
Comment 3 Jeremy Allison 2009-10-14 14:47:08 UTC 
Created attachment 4848 [details]
git-am format patch for 3.4.3.

Correct fix - initializes sid_str to NULL so we don't free an uninitialized pointer.
Jeremy.
Comment 4 Jeremy Allison 2009-10-14 14:50:36 UTC 
Created attachment 4849 [details]
git-am format patch for 3.3.9.

git-am format patch for 3.3.9.

Correct fix - initializes sid_str to NULL so we don't free an uninitialized
pointer.
Jeremy.
Comment 5 Michael Adam 2009-10-14 16:28:16 UTC 
Comment on attachment 4848 [details]
git-am format patch for 3.4.3.

Yes. This is correct and we need it for 3.4.3.
Comment 6 Michael Adam 2009-10-14 16:28:57 UTC 
Comment on attachment 4849 [details]
git-am format patch for 3.3.9.

Yes. Correct and we need it for 3.3.9
Comment 7 Michael Adam 2009-10-14 16:31:15 UTC 
Karo - please apply to v3-3-test and v3-4-test.
Comment 8 Karolin Seeger 2009-10-15 07:31:12 UTC 
Sorry, too late for 3.3.9, will be included in 3.3.10.
Pushed to v3-3-test and v3-4-test.
Closing out bug report.

Thanks!