dmarkey has reported a memleak in wbcLookupSid. Fixed by 5aeb954ba938. Needs to go into 3.4 and 3.3. Patch for me applies cleanly to 3.3 with "git am -3".
Jeremy, can you take a look?
kai volunteered to ack this :-)
Ack, needs to be fixed.
Karo, 3.3 and 3.4 please (Not a blocker, but also doesn't hurt I think)
Urgggh. I hate the code in wbcLookupSid(). It's returning memory talloc'ed off the null context - no talloc context passed in. This is going to be a nightmare to make thread safe :-(.
Patch is good though - obviously correct. Re-assigning to Karolin for inclusion.
Pushed to v3-4-test and v3-3-test.
Closing out bug report.