Bug 6797 - memleak in wbcLookupSid
memleak in wbcLookupSid
Status: RESOLVED FIXED
Product: Samba 3.4
Classification: Unclassified
Component: Winbind
unspecified
Other Linux
: P3 normal
: ---
Assigned To: Karolin Seeger
Samba QA Contact
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-10-09 16:03 UTC by Volker Lendecke
Modified: 2009-10-12 03:54 UTC (History)
0 users

See Also:
jra: review?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Volker Lendecke 2009-10-09 16:03:07 UTC
dmarkey has reported a memleak in wbcLookupSid. Fixed by 5aeb954ba938. Needs to go into 3.4 and 3.3. Patch for me applies cleanly to 3.3 with "git am -3".

Volker
Comment 1 Volker Lendecke 2009-10-09 16:03:40 UTC
Jeremy, can you take a look?

Thanks,

Volker
Comment 2 Volker Lendecke 2009-10-09 16:12:07 UTC
kai volunteered to ack this :-)
Comment 3 Kai Blin 2009-10-09 16:13:53 UTC
Ack, needs to be fixed.
Comment 4 Volker Lendecke 2009-10-09 16:15:21 UTC
Karo, 3.3 and 3.4 please (Not a blocker, but also doesn't hurt I think)

Volker
Comment 5 Jeremy Allison 2009-10-09 16:15:40 UTC
Urgggh. I hate the code in wbcLookupSid(). It's returning memory talloc'ed off the null context - no talloc context passed in. This is going to be a nightmare to make thread safe :-(.

Patch is good though - obviously correct. Re-assigning to Karolin for inclusion.

Jeremy.
Comment 6 Karolin Seeger 2009-10-12 03:54:58 UTC
Pushed to v3-4-test and v3-3-test.
Closing out bug report.

Thanks!