Bug 6792 - Plugins and shared libraries should not use the same LDFLAGS
Summary: Plugins and shared libraries should not use the same LDFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.4
Classification: Unclassified
Component: Build environment (show other bugs)
Version: 3.4.2
Hardware: Other Linux
: P3 normal
Target Milestone: ---
Assignee: Björn Jacke
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-10-08 09:50 UTC by Buchan Milne
Modified: 2009-10-20 03:53 UTC (History)
0 users

See Also:

Attachments
Patch to provide separate LDFLAGS for plugins (12.80 KB, patch)
2009-10-08 09:51 UTC, Buchan Milne 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Buchan Milne 2009-10-08 09:50:15 UTC 
When building with -Wl,--no-undefined -Wl,-as-needed, linking of plugins breaks.

Plugins and shared libraries should not use the same LDFLAGS.

See http://wiki.mandriva.com/en/Underlinking#Problems_introduced_by_--no-undefined

The patch to follow may not be the correct fix, but something like it is required.
Comment 1 Buchan Milne 2009-10-08 09:51:17 UTC 
Created attachment 4820 [details]
Patch to provide separate LDFLAGS for plugins

Patch from http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/samba/current/SOURCES/samba-3.4-use-different-ldflags-plugins.patch
Comment 2 Björn Jacke 2009-10-20 03:53:05 UTC 
thanks, the patch looks like a good idea. Implemented for master and upcoming 3.5 with 438f4006. --no-undefined resp. -z defs will also be used by default starting with 3.5.