I've come across a load balancing and share management proxy that insists on Samba to announce SPARSE_FILES in the trans2 qfsinfo calls. a5cace128d from master implements the parameter share:fake_fscaps. By setting this to 64, we announce the required flag. I'd like to have this in 3.4.2.
Jeremy, can you support & ack this?
Looks good to me...
+1 from me.
shouldn't we ship one or two lines of documentation along with this?
This is deliberately undocumented (as are all parametric options), as you can probably cause a lot of trouble if you use it wrongly. And in 15 years of Samba, this is the first time I've come across a need to do it.
are there parametic options that are not documented? ldapsam:trusted ldapsam:editposix are two examples of non-vfs parametric options that can be found in smb.conf(5).
I really think undocumented options should be considered to be a bug, even undocumented parametic options. But if I'm the only one who thinks so, I'll stop complaining now :-)
My vote would be to not document it. Metze and Jeremy acked it without asking for documentation. We need to ship this for 3.4.2. So from my point of view the formal requirements have been met.
Karolin, do you agree or do we need to document all parametric options before the next release?
(In reply to comment #6)
> My vote would be to not document it. Metze and Jeremy acked it without asking
> for documentation. We need to ship this for 3.4.2. So from my point of view the
> formal requirements have been met.
> Karolin, do you agree or do we need to document all parametric options before
> the next release?
I agree as most of the parametric options are not documented. We can add documentation later on.
Ok, I was told in a private channel that I'm wrong. I'll update the patch soon.
Created attachment 4755 [details]
Patchset from master. This is two patches as it is also so in master. If needed, I can merge them to one.
Pushed to v3-4-test, will be included in 3.4.3.
Closing out bug report.