The Samba-Bugzilla – Bug 667
msdfs links with uppercase chars broken.
Last modified: 2005-08-24 10:23:22 UTC
Short version: What does msdfs.c:175 do???
Long version: If you have directories with upper-case file names
in them, you will never be able to store DFS links in there, because
is_msdfs_link will not find that link due to a strlower_m on the path.
It's a stupid bug. I'm going to remove this line. I can't see why these
names are lowercased at all.
Hmmm. This is much trickier to fix than it looks - involves unix_convert
and also the statcache....
Ok, I have a proposed patch for this (attached). Volker, can you
test this ?
Created attachment 223 [details]
Proposed DFS case patch.
Created attachment 224 [details]
init localpath in resolve_dfs_path
localpath in resolve_dfs_path is used uninitialized with your patch. Also apply
the attached patch, and my brief test works fine.
Thanks for looking at that!
Volker, that fix is wrong, the correct fix is to change the pstrcat
to pstrcpy below. However, this whole patch is somewhat suspect. I've
been thinking about it over the weekend and I have a much simpler fix
Ok, Volker, please test this much simpler fix against current SAMBA_3_0
CVS. I'm pretty sure it's ok, so I'm inclined to commit it.
Created attachment 227 [details]
Better patch. I think I will commit this.
I've committed the patch. I think it's ok (seems to be in my testing).
sorry for the same, cleaning up the database to prevent unecessary reopens of bugs.