Bug 6649 - gvfsd-smb (Gnome vfs) fails to copy files from an SMB share.
gvfsd-smb (Gnome vfs) fails to copy files from an SMB share.
Product: Samba 3.4
Classification: Unclassified
Component: libsmbclient
Other Linux
: P3 regression
: ---
Assigned To: Karolin Seeger
Samba QA Contact
Depends on:
  Show dependency treegraph
Reported: 2009-08-19 17:42 UTC by Jeremy Allison
Modified: 2010-11-09 02:55 UTC (History)
2 users (show)

See Also:

Patch for 3.4.1. (569 bytes, patch)
2009-08-19 17:44 UTC, Jeremy Allison
vl: review+
A wireshark pcap trace of gvfs-copy generating invalid argument error (87.99 KB, application/octet-stream)
2010-11-09 02:55 UTC, Oded Arbel
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Allison 2009-08-19 17:42:18 UTC
See RedHat bugzilla bug :


and gnome bugzilla bug:

for details.
Comment 1 Jeremy Allison 2009-08-19 17:44:58 UTC
Created attachment 4577 [details]
Patch for 3.4.1.

This is the fix for 3.4.1. It's a showstopper that must go in.
If the size returned from a read is zero (end of file read) the comparison of :

buf < bytes

is always true (the offset to the bytes returned in the packet is set at zero if there are no bytes returned). This triggers an OOB error which causes NT_STATUS_INVALID_NETWORK_RESPONSE to be returned.

Volker please review and assign to Karolin for inclusion in 3.4.1.

Already fixed in master with commit 33d27797d3ae9ab3ff7e1aa940941cc450f5ad1d.

Comment 2 Volker Lendecke 2009-08-21 05:28:30 UTC
Comment on attachment 4577 [details]
Patch for 3.4.1.

Thanks a lot for that patch! And sorry for not fixing it myself :-(

Comment 3 Karolin Seeger 2009-08-21 05:48:06 UTC
Patch will be included in 3.4.1.
Closing out bug report.

Comment 4 Oded Arbel 2010-11-08 01:59:51 UTC
This issues seems to be reoccurring with Samba 3.5 on Ubuntu 10.10 ( https://bugs.launchpad.net/ubuntu/+source/gvfs/+bug/393012 ) and Fedora 14 ( https://bugzilla.redhat.com/show_bug.cgi?id=598620 ). As expected it has also been re-reported again as a GNOME bug ( https://bugzilla.gnome.org/show_bug.cgi?id=633937 ) even though its consistent across other smbclient users.
Comment 5 Jeremy Allison 2010-11-08 18:34:44 UTC
Just checking - can't reproduce this with Ubuntu 10.04. Is this a 10.10 bug only ?
Comment 6 Oded Arbel 2010-11-08 18:46:55 UTC
That is correct - the problem came back with the upgrade to Ubuntu 10.10.
Comment 7 Oded Arbel 2010-11-09 02:55:05 UTC
Created attachment 6055 [details]
A wireshark pcap trace of gvfs-copy generating invalid argument error

This was generated on Ubuntu 10.10 with libsmbclient 3.5.4