Bug 6628 - "smbpasswd -a" uses algorithmic rid base with "passdb backend = tdbsam"
Summary: "smbpasswd -a" uses algorithmic rid base with "passdb backend = tdbsam"
Status: RESOLVED FIXED
Alias: None
Product: Samba 3.2
Classification: Unclassified
Component: Client tools (show other bugs)
Version: 3.2.13
Hardware: Other Linux
: P3 regression
Target Milestone: ---
Assignee: Karolin Seeger
QA Contact: Samba QA Contact
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-11 08:55 UTC by Michael Adam
Modified: 2009-08-12 07:03 UTC (History)
1 user (show)

See Also:

Attachments
Fix for 3.2 (1.11 KB, patch)
2009-08-12 06:41 UTC, Michael Adam 		metze: review+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Adam 2009-08-11 08:55:43 UTC 
With current samba 3.2, smbpasswd -a does not use the tdbsam method tdbsam_new_rid() for allocating a new rid for the user to be created but
the algorighmic rid calculation instead. It should use the tdbsam method which (in 3.2) looks into the winbindd idmap tdb for the RID_COUNTER.

It seems that the tdb passdb methods are not propoerly investigated.

pdbedit on the other hand, behaves correctly, as does the server.

smbpasswd also does not complain (as it should) when "passdb backend = tdb" is used together with "algorithmic rid base" in smb.conf.

I consider this bug a blocker for the next 3.2 release.

Michael
Comment 1 Michael Adam 2009-08-12 06:41:01 UTC 
Created attachment 4544 [details]
Fix for 3.2

Just when I had tracked the bug down,
I noticed that Simo had already fixed this for 3-3 in July 2008. :-}

Attached find Simo's backported original patch with an adapted
commit message headline.

Metze, could you review this, please?

Cheers - Michael
Comment 2 Stefan Metzmacher 2009-08-12 06:52:03 UTC 
Comment on attachment 4544 [details]
Fix for 3.2

looks good
Comment 3 Karolin Seeger 2009-08-12 07:03:04 UTC 
Will be included in 3.2.14.
Closing out bug report.

Thanks!